WIP: [DocDB] Add additional logging about SST files #25465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Rhythm-26
changed the title
1 task
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ttyusupov
requested changes
Jan 16, 2025
| @@ -76,6 +76,8 @@ struct TableProperties { | |||
| // The name of the filter policy used in this table. | |||
| // If no filter policy is used, `filter_policy_name` will be an empty string. | |||
| std::string filter_policy_name; | |||
| // Cache key prefix used for detecting collision of SST table. | |||
| std::string cache_key_prefix = ""; | |||
There was a problem hiding this comment.
metadata_cache_key_prefix_hex_str?
BTW, do we need data file cache key prefix as well?
| hex_stream << static_cast<unsigned int>( | ||
| static_cast<unsigned char>(rep_->metadata_writer->compressed_cache_key_prefix.data[i])); | ||
| } | ||
| rep_->props.cache_key_prefix = hex_stream.str(); |
There was a problem hiding this comment.
We can just use
rep_->props.metadata_cache_key_prefix = Slice(rep_->metadata_writer->compressed_cache_key_prefix.data, rep_->metadata_writer->compressed_cache_key_prefix.size).ToDebugHexString();
| << "file_size" << fd.GetTotalFileSize(); | ||
| << "file_size" << fd.GetTotalFileSize() | ||
| << "metadata_size" << fd.GetBaseFileSize() | ||
| << "cache_key_prefix" << info.table_properties.cache_key_prefix; |
There was a problem hiding this comment.
"metadata_cache_key_prefix" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - [DocDB] Add additional logging about SST files #20880